----- Original Message ----- From: "Jean Delvare" <khali@xxxxxxxxxxxx> To: "guenter roeck" <guenter.roeck@xxxxxxxxxxxx> Cc: undersys@xxxxxxxxxxxx, lm-sensors@xxxxxxxxxxxxxx, "Durgadoss R" <Durgadoss.r@xxxxxxxxx> Sent: Friday, 2 December, 2011 12:19:25 AM Subject: Re: [PATCH] hwmon: (coretemp) Fix oops on driver load On Thu, 1 Dec 2011 08:05:42 -0800, Guenter Roeck wrote: > On Thu, 2011-12-01 at 05:00 -0500, Jean Delvare wrote: > > On Thu, 1 Dec 2011 01:26:39 +0100, Jean Delvare wrote: > > > On Thu, 01 Dec 2011 07:25:15 +0800 (HKT), undersys wrote: > > > > Hi All, > > > > > > > > I can no longer load the core temp module, it gives me the following kernel Opps. > > > > (...) > > > > This used to work fine before I updated the kernel to 3.0.x. (...) > > > > > > Ah, yes, I can reproduce that, and the bug is pretty obvious. I'll send > > > a patch tomorrow. > > > > > > Meanwhile you may be able to work around the problem by installing the > > > microcode_ctl package and ensuring that the microcode is updated before > > > loading the coretemp driver. > > > > If the CPU microcode is too old, the coretemp driver won't work. But > > instead of failing gracefully, it currently oops. Check for NULL > > platform device data to avoid this. > > > > Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx> > > Cc: Fenghua Yu <fenghua.yu@xxxxxxxxx> > > Cc: Durgadoss R <Durgadoss.r@xxxxxxxxx> > > Cc: Guenter Roeck <guenter.roeck@xxxxxxxxxxxx> > Acked-by: Guenter Roeck <guenter.roeck@xxxxxxxxxxxx> Thanks. > Jean, how do we send this to Greg ? stable@xxxxxxxxxxxxxxx ? Yes. I'll do so right now. -- Jean Delvare I've now got the latest microcode from Intel loading fine. The coretemp module still will case an "OPPS" but the new code will solve that from what i understand but it also still means that coretemp no longer pics up my CPU temp.. Thanks _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors