Re: [PATCH] hwmon: (pmbus) Fix two issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Problem solved.
This driver is perfect.
The i2c bus driver need to be modified to support I2C_FUNC_SMBUS_READ_BLOCK_DATA,
Just like Guenter's patch.
Maybe other i2c bus drivers need to be modified too.

Thanks you guys!

Regards,
Yuantian

> -----Original Message-----
> From: Guenter Roeck [mailto:guenter.roeck@xxxxxxxxxxxx]
> Sent: 2011年11月15日 12:15
> To: Tang Yuantian-B29983
> Cc: Jean Delvare; Huang Changming-R66093; Tabi Timur-B04825; lm-
> sensors@xxxxxxxxxxxxxx
> Subject: Re:  [PATCH] hwmon: (pmbus) Fix two issues
> > I2C_FUNC_SMBUS_READ_BLOCK_DATA support, The return value is not correct.
> >
> Actually, you are right. The i2c-mpc driver would also have to handle the
> I2C_M_RECV_LEN flag, where the 1st received byte indicates the receive
> length. That would probably require a change in mpc_read(), telling it
> that the first byte to be received is the length.
> Something like the attached. Completely untested, of course ...
> 
> Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors



[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux