Re: [PATCH] Drivers: hwmon: it87: Add support for ITE 8728

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 14 November 2011 19:14, Gustavo De Nardin (spuk) <gustavodn@xxxxxxxxx> wrote:
>> On Fri, 2011-11-04 at 00:44 -0400, Frank T. Lofaro Jr. wrote:
>> > This patch allows the ITE 8728 chip to be detected and used.
>> > The chip appears to be compatible with the 8721.
>>
>> Can anyone confirm that those chips are actually compatible ?
>
> Unlike forcing the other chips' ids, with force_id=0x8721 PWM control seems
> to work reasonably, with pwm1_enable=1, pwm1=0 yields around 1132 RPM on the
> CPU fan, and pwm1=255 yields around 3260 RPM.  Should pwm1=0 actually stop
> the fan?  I get what (empirically) seem to be consistent logarithmic
> increase in RPM when increasing pwm1 value, anyway.
>
> But the sensors values read with 'it87 force_id=0x8721' don't seem ok, I get
> this (first 'it87 force_id=0x8721', then 'asus_atk0110 new_if=1', which
> seems to provide good readings):
--8<--snip--8<--
>
> This is on an Asus M5A78L-M/USB3 mainboard.

Sorry, forgot to add software versions: Arch Linux with lm_sensors
3.3.1-2 and kernel 3.1.0-4-ARCH.

t'

>>
>> Thanks,
>> Guenter
>>
>> Signed-off-by: Frank T. Lofaro Jr. <ftlofaro at yahoo.com>
>> > ---
>> >  drivers/hwmon/it87.c |    3 +++
>> >  1 files changed, 3 insertions(+), 0 deletions(-)
>> >
>> > diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c
>> > index d912649..0b21d18 100644
>> > --- a/drivers/hwmon/it87.c
>> > +++ b/drivers/hwmon/it87.c
>> > @@ -17,6 +17,7 @@
>> >   *            IT8720F  Super I/O chip w/LPC interface
>> >   *            IT8721F  Super I/O chip w/LPC interface
>> >   *            IT8726F  Super I/O chip w/LPC interface
>> > + *            IT8728F  Super I/O chip w/LPC interface
>> >   *            IT8758E  Super I/O chip w/LPC interface
>> >   *            Sis950   A clone of the IT8705F
>> >   *
>> > @@ -135,6 +136,7 @@ static inline void superio_exit(void)
>> >  #define IT8720F_DEVID 0x8720
>> >  #define IT8721F_DEVID 0x8721
>> >  #define IT8726F_DEVID 0x8726
>> > +#define IT8728F_DEVID 0x8728
>> >  #define IT87_ACT_REG  0x30
>> >  #define IT87_BASE_REG 0x60
>> >
>> > @@ -1603,6 +1605,7 @@ static int __init it87_find(unsigned short
>> > *address,
>> >                 sio_data->type = it8720;
>> >                 break;
>> >         case IT8721F_DEVID:
>> > +       case IT8728F_DEVID:
>> >                 sio_data->type = it8721;
>> >                 break;
>> >         case 0xffff:    /* No device at all */
>> > --
>> > 1.7.7.2
>
> --
> ::question = (bool) _2b||!_2b;
>



-- 
(nil)

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors



[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux