Re: [PATCH RFC] hwmon: Add notification and uevent support to sysfs ABI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Guenter,

> -----Original Message-----
> From: Guenter Roeck [mailto:guenter.roeck@xxxxxxxxxxxx]
> Sent: Monday, September 19, 2011 12:55 AM
> To: Jean Delvare
> Cc: R, Durgadoss; Lucas Stach; Hans de Goede; lm-sensors@xxxxxxxxxxxxxx; linux-
> doc@xxxxxxxxxxxxxxx; Guenter Roeck
> Subject: [PATCH RFC] hwmon: Add notification and uevent support to sysfs ABI
> 
> Some hwmon drivers start adding support for alarm attribute notifications and
> generate uevents. Standardize the ABI to be used for this purpose.
> 
> Signed-off-by: Guenter Roeck <guenter.roeck@xxxxxxxxxxxx>
> ---
> An attempt to standardize notification and uevent support for hwmon drivers.
> 
>  Documentation/hwmon/sysfs-interface |   30 ++++++++++++++++++++++++++++++
>  1 files changed, 30 insertions(+), 0 deletions(-)
> 
> diff --git a/Documentation/hwmon/sysfs-interface b/Documentation/hwmon/sysfs-
> interface
> index e65e7e8..735d33f 100644
> --- a/Documentation/hwmon/sysfs-interface
> +++ b/Documentation/hwmon/sysfs-interface
> @@ -97,6 +97,16 @@ update_interval	The interval at which the chip will update
> readings.
>  		Some devices have a variable update rate or interval.
>  		This attribute can be used to change it to the desired value.
> 
> +notification	This attribute exists if the driver supports notifications on
> +		alarm and trigger attributes. Valid attribute values are:
> +		0: The driver does not support notifications or uevents.
> +		1: The driver supports notifications.
> +		2: The driver generates a uevent if an alarm or trigger status
> +		   changes.
> +		3: The driver suports notifications and generates a uevent if

s/suports/supports

> +In addition to notifications, drivers may also support uevents. If so, a
> uevent
> +shall be triggered whenever an alarm or trigger attribute changes its state.
> +The uevent shall be triggered on the driver's hwmon device kobject
> +(TBD: on the platform device kobject ?).

I would prefer the uevent to be on the hwmon device kobject.
This way the user space can look for uevents from hwmon 'subsystem'.
Then it can retrieve the exact device location from DEVPATH
attribute.

Thanks,
Durga

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux