Hi, On Wed, 31 Aug 2011, Keerthy wrote: > On chip temperature sensor driver. The driver monitors the temperature of > the MPU subsystem of the OMAP4. It sends notifications to the user space if > the temperature crosses user defined thresholds via kobject_uevent interface. > The user is allowed to configure the temperature thresholds vis sysfs nodes > exposed using hwmon interface. I commented in a separate post that this driver should probably use an MFD driver for the System Control Module accesses, and then this hwmon driver should use functions from that to access the BANDGAP temperature sensor registers[1]. But I had another comment on this driver. A similar sensor is available on the OMAP34xx[2], OMAP36xx[3], and OMAP4430[4] chips. There are some register layout differences; the thermal shutdown threshold is configurable on the 4460 but fixed on the 4430; and also I'd assume, without looking, that the temperature mapping table is different on different chips. So it would seem to make sense to move the chip-specific code and data into chip-specific source files. I could see keeping a generic filename like "omap_temp_sensor.c" if you implemented a common interface to the bandgap sensors, ADCs and comparators, across all those different chips. That might be worth thinking about. But at least, this should probably be named drivers/hwmon/omap4460_temp_sensor.c, or something similar. - Paul 1. Walmsley, Paul. _Re: [PATCH 4/6 V4] OMAP4: Hwmod: OMAP temperature sensor_. Posted to the linux-omap@xxxxxxxxxxxxxxx list on Wed, 31 Aug 2011 17:16:44 -0600. Available from (among others): http://marc.info/?l=linux-omap&m=131483260632685&w=2 2. Section 7.4.6 "Band Gap Voltage and Temperature Sensor". _OMAP34xx Multimedia Device Silicon Revision 3.1.x Version R (SWPU223R)_ (public version). Available from http://focus.ti.com/pdfs/wtbu/OMAP34xx_ES3.1.x_PUBLIC_TRM_vZR.zip 3. Section 13.4.6 "Band Gap Voltage and Temperature Sensor". _OMAP36xx Multimedia Device Silicon Revision 1.x Version V (SWPU177V)_ (public version). Available from http://focus.ti.com/pdfs/wtbu/OMAP36xx_ES1.x_PUBLIC_TRM_vV.zip 4. Section 18.4.10 "Band Gap Voltage and Temperature Sensor". _OMAP4430 Multimedia Device Silicon Revision 2.x Version V (SWPU231V)_ (public version). Available from http://focus.ti.com/pdfs/wtbu/OMAP4430_ES2.x_PUBLIC_TRM_vV.zip _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
