Hi Matthew, > The applesmc driver is current a platform device with DMI matching. All > machines with the appropriate hardware actually expose it via an acpipnp > device, so it makes sense to use that rather than hardcoding model names > and addresses. Sounds good, but has the approach been tested on a representative set of machines? > Signed-off-by: Matthew Garrett <mjg@xxxxxxxxxx> > --- > drivers/hwmon/applesmc.c | 660 +++++++++++++++++++++++++-------------------- > 1 files changed, 367 insertions(+), 293 deletions(-) The patch seems to do too many things - switching from static variables to a dev struct, adding dev parameters to all functions, changing to dynamic initialization, changing from platform to pnp device. Two patches with no functional changes to start with, then another two to turn on pnp seems reasonable. Thanks, Henrik _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
