On Tue, Jul 12, 2011 at 12:03:25PM -0400, Jean Delvare wrote: > On Tue, 12 Jul 2011 06:40:57 -0700, Guenter Roeck wrote: > > On Tue, Jul 12, 2011 at 03:00:16AM -0400, Jean Delvare wrote: > > > Hi Guenter, > > > > > > On Mon, 11 Jul 2011 12:04:24 -0700, Guenter Roeck wrote: > > > > Using integer variable types for register to data conversions can cause > > > > overflows especially for power calculations, which are in microwatt. > > > > Use long variables instead. > > > > > > I have no objection, using longs for calculations certainly makes > > > sense, however does it really help in practice? I thought that > > > sizeof(int) == sizeof(long) for all architectures on Linux? > > > > > No ... for x86_64 long is 64 bit and int is 32 bit. > > D'oh, you're right. Will I ever remember this... > > > I'll may have > > to switch to "long long" at some point, though, or maybe s64. > > Still hesitating to do that. > > I'd think twice about it (and how to do it exactly)... I think long > long is relatively expensive on 32-bit x86? > That is my concern ... I think I'll wait with that change until someone actually needs it. Guenter _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
