On Sun, Jul 10, 2011 at 11:46:40AM -0400, Jean Delvare wrote:
> Hi Guenter,
>
> On Fri, 8 Jul 2011 09:25:45 -0700, Guenter Roeck wrote:
> > Index: prog/detect/sensors-detect
> > ===================================================================
> > --- prog/detect/sensors-detect (revision 5983)
> > +++ prog/detect/sensors-detect (working copy)
> > @@ -1008,6 +1008,11 @@
> > i2c_addrs => [0x2b, 0x19, 0x2a],
> > i2c_detect => sub { lm95231_detect(@_, 1); },
> > }, {
> > + name => "National Semiconductor LM95245",
> > + driver => "lm95245",
> > + i2c_addrs => [0x2b, 0x19, 0x2a],
>
> The datasheet I have lists the following 5 addresses instead: 0x18,
> 0x19, 0x29, 0x4C and 0x4D, and the lm95245 driver agrees.
>
> > + i2c_detect => sub { lm95231_detect(@_, 2); },
> > + }, {
> > name => "National Semiconductor LM63",
> > driver => "lm63",
> > i2c_addrs => [0x4c],
> > @@ -4540,7 +4545,7 @@
> > return 5;
> > }
> >
> > -# Chip to detect: 0 = LM95231, 1 = LM95241
> > +# Chip to detect: 0 = LM95231, 1 = LM95241, 2 = LM95245
> > # Registers used:
> > # 0x02: Status (3 unused bits)
> > # 0x03: Configuration (3 unused bits)
> > @@ -4557,6 +4562,7 @@
> > return if $mid != 0x01; # National Semiconductor
> > return if $chip == 0 && $cid != 0xa1; # LM95231
> > return if $chip == 1 && $cid != 0xa4; # LM95241
> > + return if $chip == 2 && $cid != 0xb3; # LM95245
> >
> > return if i2c_smbus_read_byte_data($file, 0x02) & 0x70;
> > return if i2c_smbus_read_byte_data($file, 0x03) & 0x89;
>
> These checks for unused bits were OK for the LM95231/LM95241 but not
> for the LM95245.
>
Sigh. Must have been late.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
