Re: [PATCH v7] drivers/hwmon NTC Thermistor Initial Support v7

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 14, 2011 at 01:36:06AM -0400, Donggeun Kim wrote:
> This patch adds support for NTC Thermistor series. In this release, the
> following thermistors are supported: NCP15WB473, NCP18WB473, NCP03WB473,
> and NCP15WL333. This driver is based on the datasheet of MURATA.
> 
> The driver in the patch does conversion from the raw ADC value
> (either voltage or resistence) to temperature. In order to use
> voltage values as input, the circuit schematics should be provided
> with the platform data. A compensation table for each type of thermistor
> is provided for the conversion.
> 
> Signed-off-by: Donggeun Kim <dg77.kim@xxxxxxxxxxx>
> Signed-off-by: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>
> Signed-off-by: KyungMin Park <kyungmin.park@xxxxxxxxxxx>
> 
Hi,

Test compile resulted in:

drivers/hwmon/ntc_thermistor.c: In function âget_temp_mCâ:
drivers/hwmon/ntc_thermistor.c:174: warning: âmidâ may be used uninitialized in this function
drivers/hwmon/ntc_thermistor.c:174: note: âmidâ was declared here

Please fix.

Also, please make the following changes:

- In Documentation/hwmon/ntc-thermistor, please list correct prefix values.
- Please add EXPERIMENTAL Kconfig dependency.
- Please change MODULE_ALIAS to "platform:ntc-thermistor".

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors



[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux