Re: [PATCH 4/5] hwmon: (ibmpex) Initialize sysfs attributes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 24 May 2011 13:10:13 -0700, Guenter Roeck wrote:
> Initialize dynamically allocated sysfs attributes before device_create_file()
> call to suppress lockdep_init_map() warning if lockdep debugging is enabled.
> 
> Signed-off-by: Guenter Roeck <guenter.roeck@xxxxxxxxxxxx>
> ---
> Compile tested only.

Can't test either, but looks good to me:

Acked-by: Jean Delvare <khali@xxxxxxxxxxxx>

Candidate for stable series?

> 
>  drivers/hwmon/ibmpex.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/hwmon/ibmpex.c b/drivers/hwmon/ibmpex.c
> index 06d4eaf..41dbf81 100644
> --- a/drivers/hwmon/ibmpex.c
> +++ b/drivers/hwmon/ibmpex.c
> @@ -358,6 +358,7 @@ static int create_sensor(struct ibmpex_bmc_data *data, int type,
>  	else if (type == POWER_SENSOR)
>  		sprintf(n, power_sensor_name_templates[func], "power", counter);
>  
> +	sysfs_attr_init(&data->sensors[sensor].attr[func].dev_attr.attr);
>  	data->sensors[sensor].attr[func].dev_attr.attr.name = n;
>  	data->sensors[sensor].attr[func].dev_attr.attr.mode = S_IRUGO;
>  	data->sensors[sensor].attr[func].dev_attr.show = ibmpex_show_sensor;


-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux