On Tue, 31 May 2011 13:29:18 -0700, Guenter Roeck wrote: > On Tue, 2011-05-31 at 15:50 -0400, Jean Delvare wrote: > > The current temperature range check of MSR_IA32_TEMPERATURE_TARGET > > seems too strict to me, some TjMax values documented in > > Documentation/hwmon/coretemp wouldn't pass. Relax the check so that > > all the documented values pass. > > > Maybe the reason is that the processors which support reading TjMax via > the register are all in the 80 .. 120 range. Who knows - unfortunately, > a simple table describing which processor supports which set of > registers does not seem to exist, or at least I was unable to find it. > > > Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx> > > Cc: Carsten Emde <C.Emde@xxxxxxxxx> > > Cc: Fenghua Yu <fenghua.yu@xxxxxxxxx> > > > --- > > I'm not even sure why we need to check the range. Why would the > > value read from the MSR be wrong? > > If I understand correctly, some processors support the register but not > the TjMax value in bits 16..23. Here is an exchange about it: > > http://www.tomshardware.com/forum/230079-29-intel-tjunction-mean OK but then the value in these bits would be 0, not a random value, right? Wouldn't checking for val != 0 be more appropriate than the heuristic we have? -- Jean Delvare _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
