Re: MAX6642 chip detection and other stuff

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Guenter,

On Fri, 27 May 2011 21:51:13 -0700, Guenter Roeck wrote:
> The attached patch (on top of Per's most recent patch) works quite nicely.
> Per, maybe you can just merge it with your patch and resubmit it.

Looks good, pretty much what I had in mind. But I think you could make
the code even more compact:

	/* sanity check */
	if (i2c_smbus_read_byte_data(client, 0x04) != 0x4D
	 || i2c_smbus_read_byte_data(client, 0x06) != 0x4D
	 || i2c_smbus_read_byte_data(client, 0xff) != 0x4D)
		return -ENODEV;

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux