Hi Guenter,
On Fri, 20 May 2011 07:48:00 -0700, Guenter Roeck wrote:
> Fix remaining checkpatch errors in the coretemp driver.
Most of these aren't actually reported by checkpatch. But I'm fine with
the fixes nevertheless. A few comments:
> Signed-off-by: Guenter Roeck <guenter.roeck@xxxxxxxxxxxx>
> Cc: Fenghua Yu <fenghua.yu@xxxxxxxxx>
> Cc: Durgadoss R <durgadoss.r@xxxxxxxxx>
> ---
> drivers/hwmon/coretemp.c | 66 +++++++++++++++++++++++++--------------------
> 1 files changed, 37 insertions(+), 29 deletions(-)
>
> diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> index ece3b7d..649d87d 100644
> --- a/drivers/hwmon/coretemp.c
> +++ b/drivers/hwmon/coretemp.c
> @@ -37,7 +37,7 @@
> #include <linux/pci.h>
> #include <asm/msr.h>
> #include <asm/processor.h>
> -#include <asm/smp.h>
> +#include <linux/smp.h>
Then please move it up to the <linux/*> group.
> (...)
> @@ -259,8 +264,10 @@ static int adjust_tjmax(struct cpuinfo_x86 *c, u32 id, struct device *dev)
> } else if (eax & 0x40000000) {
> tjmax = tjmax_ee;
> }
> - /* if we dont use msr EE it means we are desktop CPU (with exeception
> - of Atom) */
> + /*
> + * if we dont use msr EE it means we are desktop CPU (with exeception
While you're here, capital "I" please, and s/dont/don't/.
> + * of Atom)
> + */
> } else if (tjmax == 100000) {
> dev_warn(dev, "Using relative temperature scale!\n");
> }
> (...)
Then,
Acked-by: Jean Delvare <khali@xxxxxxxxxxxx>
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
