Re: [PATCHv8 1/1] Hwmon: Merge Pkgtemp with Coretemp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Guenter,

> Strictly speaking, the rule would be to not have any ifdefs in the code in the
> first place.
> Might be worth exploring if we can get rid of the ifdefs by using a single set
> of defines
> at the top, such as
> 
> #ifdef CONFIG_SMP
> #define phys_proc_id(cpu)	cpu_data(cpu)->phys_proc_id
> #define cpu_core_id(cpu)	cpu_data(cpu)->cpu_core_id
> #else
> #define phys_proc_id(cpu)	(cpu)
> #define cpu_core_id(cpu)	(cpu)
> #endif
> 
> If you also unconditionally declare phys_proc_id and cpu_core_id in struct
> pdev_entry,
> that should enable us to get rid of pretty much all the ifdefs in the code.
> 
> Would be great if you could do that now, or we can do it in a subsequent patch.

I am not thinking about a new patch for this :)
Shall do this change in the next version itself..

Thanks,
Durga

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux