Re: [PATCH] hwmon: (abituguru) Depend on DMI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 16, 2011 3:47 pm, Guenter Roeck wrote:
> On Mon, May 16, 2011 at 05:06:12AM -0400, Jean Delvare wrote:
>> The abituguru drivers are only built on X86, where DMI support is now
>> enabled by default. So let these drivers depend on DMI, for the
>> following gains:
>> * Robustness and safety. Detection of these devices is weak and uses
>>   non-standard methods, it should really be limited to Abit boards
>>   unless the user explicitly asks otherwise.
>> * Code simplicity. The code is easier to read without ifdefs.
>> * Better build testing coverage. Now there's only one way to build the
>>   drivers, so no risk of build failure on exotic systems.
>>
>> Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx>
>> Cc: Alistair John Strachan <alistair@xxxxxxxxxxxxx>
>> Cc: Hans de Goede <hdegoede@xxxxxxxxxx>
>
> Acked-by: Guenter Roeck <guenter.roeck@xxxxxxxxxxxx>

It's nice to see this actually happen.

Acked-by: Alistair John Strachan <alistair@xxxxxxxxxxxxx>

-- 
Cheers,
Alistair.

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux