Hi Jonathan, Excerpts from Jonathan Cameron's message of 2011-04-13 07:37:37 -0400: > On 04/12/11 20:34, Vivien Didelot wrote: > > * Move the creation of sysfs attributes after the end of the > > initialization, and remove them in the error path. > > * Release regulator in the error path. > > * Add a soft reset command (need to wait 11ms before next command). > Ideally add something to say why this is needed. (the heater issue that > Guenter raised). The soft reset in this patch just ensures to wait 11ms after this command is sent (previously the probe function didn't deal with that). The heater issue that Guenter raised (i.e. disabling the heater on module unload) is fixed in the next patch. Btw, thanks you all for you comments and reviews. Regards, Vivien. > > > > Signed-off-by: Vivien Didelot <vivien.didelot@xxxxxxxxxxxxxxxxxxxx> > Acked-by: Jonathan Cameron <jic23@xxxxxxxxx> _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
