Hi Wei, On Wed, 13 Apr 2011 19:51:48 +0800, wni@xxxxxxxxxx wrote: > From: Wei Ni <wni@xxxxxxxxxx> > > NCT1008 is the register-compatible with the ADM1032 and ADT7461, > so support it in this lm90 driver. > And add alarm function, suspend/resume callback. We already have a patch pending adding support for the NCT1008: ftp://ftp.kernel.org/pub/linux/kernel/people/jdelvare/linux-2.6/jdelvare-hwmon/hwmon-lm90-01-add-support-for-adt7461a-and-nct1008.patch Your own patch should apply on top of this, and only focus on adding support for the new features. BTW, you stand a better chance of getting your changes reviewed and accepted quickly if you split them into logical steps. For example, suspend/resume support would be useful on its own, so it could be a separate patch, etc. -- Jean Delvare _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors