Hi Fenghua, I have attached the logs of the merged coretemp driver on a SNB and non-SNB platform. Kindly review and let me know your comments. For me, the log indicates that the driver works fine. Let me know your Ack/comments on the patch too. [NON_SNB] /sys/class/hwmon/hwmon0/device --- modalias:platform:coretemp name:coretemp temp1_crit:105000 temp1_crit_alarm:0 temp1_input:23000 temp1_label:Core 0 temp1_max:89000 temp2_crit:105000 temp2_crit_alarm:0 temp2_input:25000 temp2_label:Core 2 temp2_max:89000 uevent:DRIVER=coretemp uevent:MODALIAS=platform:coretemp [SNB-With PKG Support] /sys/class/hwmon/hwmon1/device --- modalias:platform:coretemp name:coretemp temp1_crit:100000 temp1_crit_alarm:0 temp1_input:37000 temp1_label:Physical id 0 temp1_max:86000 temp2_crit:100000 temp2_crit_alarm:0 temp2_input:30000 temp2_label:Core 0 temp2_max:86000 temp3_crit:100000 temp3_crit_alarm:0 temp3_input:37000 temp3_label:Core 1 temp3_max:86000 temp4_crit:100000 temp4_crit_alarm:0 temp4_input:29000 temp4_label:Core 2 temp4_max:86000 temp5_crit:100000 temp5_crit_alarm:0 temp5_input:36000 temp5_label:Core 3 temp5_max:86000 uevent:DRIVER=coretemp uevent:MODALIAS=platform:coretemp Thanks, Durga > -----Original Message----- > From: Yu, Fenghua > Sent: Monday, April 04, 2011 11:47 PM > To: R, Durgadoss; guenter.roeck@xxxxxxxxxxxx; khali@xxxxxxxxxxxx > Cc: lm-sensors@xxxxxxxxxxxxxx > Subject: RE: [PATCH:hwmon:v4:]Merging_pkgtemp_with_coretemp > > > This patch merges the pkgtemp driver with the coretemp driver. > > This merged driver creates one hwmon device per physical CPU. > > > > Changes from v3 of this patch: > > Added appropriate support for CONFIG_HOTPLUG_CPU. > > > > Signed-off-by: Durgadoss R <durgadoss.r@xxxxxxxxx> > > --- > > drivers/hwmon/coretemp.c | 618 ++++++++++++++++++++++++++++++++++---- > > -------- > > 1 files changed, 455 insertions(+), 163 deletions(-) > > You patch needs to remove pkgtemp.c file as well. > > Please publish your test results on Sandybridge and non-Sandybridge. > > Thanks. > > -Fenghua
Attachment:
non_snb_coretemp.log
Description: non_snb_coretemp.log
Attachment:
snb_coretemp.log
Description: snb_coretemp.log
_______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
