Re: [PATCH] hwmon: Add tachometer pulses per fan revolution to sysfs ABI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2 Mar 2011 15:23:58 -0800, Guenter Roeck wrote:
> Some fan control chips support a configuration register to set the number of
> tachometer pulses per fan revolution. Add an ABI attribute to support this
> configuration register.
> 
> Signed-off-by: Guenter Roeck <guenter.roeck@xxxxxxxxxxxx>
> ---
>  Documentation/hwmon/sysfs-interface |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/Documentation/hwmon/sysfs-interface b/Documentation/hwmon/sysfs-interface
> index c6559f1..134c6a4 100644
> --- a/Documentation/hwmon/sysfs-interface
> +++ b/Documentation/hwmon/sysfs-interface
> @@ -187,6 +187,12 @@ fan[1-*]_div	Fan divisor.
>  		Note that this is actually an internal clock divisor, which
>  		affects the measurable speed range, not the read value.
>  
> +fan[1-*]_pulses	Number of tachometer pulses per fan revolution.

It might be good to specify that this is a characteristic of the fan
connected to the device's input, so you have to set the value in
accordance with the fan model.

> +		Integer value, typically between 1 and 4.
> +		RW
> +		Should only be created if the chip has a register to configure
> +		the value.

You could mention that, in the absence of register (and thus attribute)
the value assumed by all devices is 2 pulses per fan revolution because
almost all fans do this.

> +
>  fan[1-*]_target
>  		Desired fan speed
>  		Unit: revolution/min (RPM)

I'm fine with this new attribute. We'll need support in libsensors too,
so that users can change the settings through configuration file +
"sensors -s".

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux