Hi! On 01/18/2011 05:31 PM, Guenter Roeck wrote: >> Signed-off-by: Roland Stigge <stigge@xxxxxxxxx> >> > Bunch of comments below. This is not a complete review; the driver will need > some cleanup to enable that. Thanks for your notes! I took the max6639.c from He Changqing of semptian.net. Extended and cleaned it up quite a bit, but surely it was still not enough. Will send the updated version in a separate patch mail where I considered all your suggestions. fan_div in the register and maintained separately is a bit tricky. You have it in Register 0x24. But also, you have a ratio between "selected pulses per revolution" and "actual ppr", see page 14, table 7, in the datasheet. I guess He Changqing tried to model this in the initial semptian.net version of the driver by handling fan_div independently from the reg. For now, I'm moving fan_div to platform_data's ppr (pulses per rotation), because it doesn't fit our sysfs' fan_div definition (powers of two). In a future update, I can try to adjust the fan rpm range automatically. Still need a robust strategy because we need to guard against hardware failures (what this interface is about in the first place). Also doing via platform_data's rpm_range for now. Thanks in advance! Roland -- Dipl.-Inf. Roland Stigge SATCOM Technologies ********************************************************** WORK Microwave GmbH Raiffeisenstrasse 12 83607 Holzkirchen Germany Tel: +49 8024 6408-0 Fax: +49 8024 6408-40 roland.stigge@xxxxxxxxxxxxxxxxx http://www.work-microwave.de./ GeschÃftsfÃhrer / Managing Directors: Dr. Andreas Hausotter (CEO), Dr. GÃnter Prokoph (CTO) Sitz / Reg. Office: Holzkirchen, Germany Reg. HRB MÃnchen Nr. 79479 ISO 9001:2008 certificate This message and any attachments may contain confidential information and must not be disclosed to a third party without the prior written consent of Work Microwave GmbH, Germany. If you have received it erroneously, please discard it and contact us by return. ********************************************************** _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
