Re: [PATCH] Support for DS620

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 07, 2011 at 05:24:21AM -0500, Roland Stigge wrote:
> Hi,
> 
> On 01/07/2011 02:39 AM, Guenter Roeck wrote:
> >> I'm attaching my updated patch. You can also merge from git.antcom.de,
> >> repo linux-2.6, branch ds620.
> >>
> >> I also added a runtime configuration device attribute for the thermostat
> >> functionality.
> >>
> > Unfortunately, that adds a non-standard and non-documented ABI attribute, so no one
> > will be able to use it. Also, from reading the specification, it seems like it would more
> > appropriate to set this through platform data (if it really has to be configurable).
> 
> Oops, sorry!
> 
> What can we do if we want to make it configurable at runtime? I'm not
> using it currently this way, but users could be. Or should we just make
> ist platform data to adhere to spec restrictions?
> 
I would suggest to implement it as platform data. If anyone ever needs it runtime-configurable,
we can still think about some way to do it.

> > Btw, can you write Documentation/hwmon/ds620 ? I completely forgot to ask for that.
> 
> It was already included in the last patches, since you already asked
> about it. :-)
> 
I must be blind :(.

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux