On Wed, Jan 05, 2011 at 11:17:37PM -0500, Keerthy wrote: > Introducing a driver for MADC on TWL4030 powerIC. MADC stands for monitoring > ADC. This driver monitors the real time conversion of analog signals like > battery temperature, battery type, battery level etc. User can also ask for > the conversion on a particular channel using the sysfs nodes. Tested the > conversion through sysfs nodes. Tested with DEBUG_LOCKDEP enabled. > > Signed-off-by: Keerthy <j-keerthy@xxxxxx> > --- > NACK for: [...] > +EXPORT_SYMBOL_GPL(twl4030_madc_conversion); [...] > +EXPORT_SYMBOL_GPL(twl4030_get_madc_conversion); No symbol export from hwmon drivers. Other parts of the kernel should not depend on HWMON configuration. I would suggest to check if drivers/staging/iio would be a better fit. Guenter _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
