Re: Patch[2/2] Adding Interrupt Handling Support to Coretemp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > From: Durgadoss R <durgadoss.r@xxxxxxxxx>
> >
> > Date: Tue, 7 Dec 2010 04:10:41 +0530
> > Subject: [PATCH 2/2] Adding_Threshold_Interrupt_Handling_to_Coretemp
> >
> > This patch adds the interrupt handling for the core/package
> > thermal thresholds in coretemp. The interrupts are routed to coretemp
> > via therm_throt.c. Whenever an interrupt occurs, a notification is sent
> > in the form of a netlink event to the user space.
> >
> > Signed-off-by: Durgadoss R <durgadoss.r@xxxxxxxxx>
> >
> After browsing through this and the previous patch, I think the functionality
> should reside outside and be independent of hwmon. arch/x86/kernel/cpu or
> drivers/platform/x86 might be better places for it, though I am not really
> in a position to make that judgement.

I added the threshold support to hwmon because the existing coretemp
driver provided a nice infrastructure for this. For eg: I do not
have to create functions for reading current temperature, detecting
the CPU model, checking the DTS support etc..

But If you are saying that, the coretemp driver itself(not just
the threshold functionality), should be in a different location,
then, as you said, I am also not in a position to make the judgement.

Thanks,
Durgadoss

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux