On 12/01/10 09:00, Jean Delvare wrote: > On Wed, 1 Dec 2010 10:44:07 +0530, Chethan Krishna N wrote: >> From: Chethan Krishna N <chethan.krishna@xxxxxxxxxxxxxx> >> >> lsm303dlh accelerometer magnetometer device support added. >> Also provides input device support through interrupts. >> >> Signed-off-by: Chethan Krishna N <chethan.krishna@xxxxxxxxxxxxxx> >> --- >> drivers/hwmon/Kconfig | 23 + >> drivers/hwmon/Makefile | 1 + >> drivers/hwmon/lsm303dlh_a.c | 1112 +++++++++++++++++++++++++++++++++++++++++++ >> drivers/hwmon/lsm303dlh_m.c | 764 +++++++++++++++++++++++++++++ >> include/linux/lsm303dlh.h | 56 +++ >> 5 files changed, 1956 insertions(+), 0 deletions(-) >> mode change 100644 => 100755 drivers/hwmon/Kconfig >> create mode 100644 drivers/hwmon/lsm303dlh_a.c >> create mode 100644 drivers/hwmon/lsm303dlh_m.c >> create mode 100644 include/linux/lsm303dlh.h > > Nack. This isn't a hardware monitoring driver, so it has nothing to do > in drivers/hwmon. Please find a better place. > Current options are: * persuade Dmitry it is primarily a human input device and go for drivers/input * drivers/misc * drivers/staging/iio (couple of magnetometers and more general IMU's in there already, but then if you primary use is input, the input bridge is only at proof of concept stage at the moment). Take your pick. Where ever it physically gets located, the abi needs to ideally match existing ones (particularly all those sysfs attributes). If you want to change things in existing abi's then feel free to propose doing so. What won't be acceptable anywhere in mainline is to add completely different ones when existing options are in use in other drivers (without a very good reason and explanation.) Jonathan cc'd Dmitry (who, as input maintainer should have been cc'd on original email) _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
