On Wed, Sep 29, 2010 at 12:48:13PM -0400, Jean Delvare wrote: > Hi Guenter, > > On Fri, 17 Sep 2010 20:30:42 -0700, Guenter Roeck wrote: > > Signed-off-by: Guenter Roeck <guenter.roeck@xxxxxxxxxxxx> > > --- > > drivers/hwmon/lm90.c | 523 ++++++++++++++++++++++++------------------------- > > 1 files changed, 256 insertions(+), 267 deletions(-) > > > > Wow. Have you noticed how GNU diff gets this patch completely wrong? I > use quilt and quilt relies in GNU diff, and when refreshing or viewing > the patch, I get an output which is different from what you sent, > larger and less readable. It includes oddities such as: > > - if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA)) > - return -ENODEV; > + if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA)) > + return -ENODEV; > > And this isn't a bug in a specific version... Tried it on 4 different > versions of GNU diff on 2 completely different distributions. "diff -d" > gets it right, but the default algorithm does not. > Interesting. I had noticed similar problems before, but for kernel development I use only git so I didn't see it. > I'll report the bug to the diffutils guys. Meanwhile, your patch is > nice and I'll apply it... > Thanks ... Guenter _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
