Hi Jean, I had a closer look into the w83795 driver - this time trying to ignore coding style problems ;) - and noticed that there are several attributes which are not defined in the ABI. I don't mind extending the ABI - done it several times myself recently, after all - but this is pretty much creating a new fan / pwm control ABI. Or, after looking into other drivers, it is using and possibly extending undocumented ABI attributes defined in other drivers. Are we ready for that, ie are you sure that the ABI extensions are sane and fit the requirements of other drivers ? If yes, should this ABI be documented ? Also, do you plan to write Documentation/hwmon/w83795 ? That seems to be missing in your patchset. Thanks, Guenter _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
