Re: [PATCH 5/6] hwmon: (pc87427) Add temperature monitoring support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Guenter,

On Thu, 12 Aug 2010 10:37:17 -0700, Guenter Roeck wrote:
> On Wed, 2010-08-11 at 11:13 -0400, Jean Delvare wrote:
> > Add support for the 6 temperature monitoring channels of the PC87427.
> > Note that the sensors resolution can vary, and I couldn't find a way
> > to figure it out, so we might have to compensate in user-space.
> > 
> > Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx>
> 
> Acked-by: Guenter Roeck <guenter.roeck@xxxxxxxxxxxx>
> 
> One question: You don't sign extend the 16 bit sensor data. Does that
> mean negative values will be reported as large positive values, or does
> the chip sign extend internally from 8/9 to 16 bit ?

The chip provides 16-bit values. What is 8- or 9-bit is the integer
part of the value. So there is no need to sign-extend anything. Which
is good because we don't even know for sure if the value is signed...
The driver assumes so because this is the most common for thermal
sensors, but it could be wrong for some setups. The issue we have
basically is that we don't know where the decimal point is :(

I'm glad that this is a rare chip, used only on a couple boards, so
that the pain is limited.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux