On Wed, 2010-07-28 at 15:00 -0400, Fenghua Yu wrote: > From: Fenghua Yu <fenghua.yu@xxxxxxxxx> > > This patch adds a hwmon driver for package level thermal control. The driver > dumps package level thermal information through sysfs interface so that upper > level application (e.g. lm_sensor) can retrive the information. > > Instead of having the package level hwmon code in coretemp, I write a seperate > driver pkgtemp because: > > First, package level thermal sensors include not only sensors for each core, > but also sensors for uncore, memory controller or other components in the > package. Logically it will be clear to have a seperate hwmon driver for package > level hwmon to monitor wider range of sensors in a package. Merging package > thermal driver into core thermal driver doesn't make sense and may mislead. > > Secondly, merging the two drivers together may cause coding mess. It's easier > to include various package level sensors info if more sensor information is > implemented. Coretemp code needs to consider a lot of legacy machine cases. > Pkgtemp code only considers platform starting from Sandy Bridge. > > On a 1Sx4Cx2T Sandy Bridge platform, lm-sensors dumps the pkgtemp and coretemp: > > pkgtemp-isa-0000 > Adapter: ISA adapter > physical id 0: +33.0°C (high = +79.0°C, crit = +99.0°C) > > coretemp-isa-0000 > Adapter: ISA adapter > Core 0: +32.0°C (high = +79.0°C, crit = +99.0°C) > > coretemp-isa-0001 > Adapter: ISA adapter > Core 1: +32.0°C (high = +79.0°C, crit = +99.0°C) > > coretemp-isa-0002 > Adapter: ISA adapter > Core 2: +32.0°C (high = +79.0°C, crit = +99.0°C) > > coretemp-isa-0003 > Adapter: ISA adapter > Core 3: +32.0°C (high = +79.0°C, crit = +99.0°C) > > Signed-off-by: Fenghua Yu <fenghua.yu@xxxxxxxxx> > Reviewed-by: Len Brown <len.brown@xxxxxxxxx> > Reviewed-by: Guenter Roeck <guenter.roeck@xxxxxxxxxxxx> That I provided feedback does not mean that I endorsed a "Reviewed-by" signature. It is inappropriate to add such a signature without my approval. Guenter _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
