Re: [PATCH 1/4] hwmon: (coretemp) adding package thermal info support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



于 7/15/2010 11:06 AM, Guenter Roeck 写道:
On Wed, Jul 14, 2010 at 10:46:41PM -0400, Chen Gong wrote:
IA32_PACKAGE_THERM_STATUS can supply a thermal status from
a package level granularity. It is shared in each physical
processor package. Now put it under /sys directory.

Signed-off-by: Chen Gong<gong.chen@xxxxxxxxxxxxxxx>
---
  Documentation/hwmon/sysfs-interface |    5 +++++
  arch/x86/include/asm/msr-index.h    |    1 +
  drivers/hwmon/coretemp.c            |   16 ++++++++++++++--
  3 files changed, 20 insertions(+), 2 deletions(-)

diff --git a/Documentation/hwmon/sysfs-interface b/Documentation/hwmon/sysfs-interface
index d4e2917..96e9f18 100644
--- a/Documentation/hwmon/sysfs-interface
+++ b/Documentation/hwmon/sysfs-interface
@@ -284,6 +284,11 @@ temp[1-*]_input Temperature input value.
  		Unit: millidegree Celsius
  		RO

+pkg_temp[1-*]_input
+		Package temperature input value.
+		Unit: millidegree Celsius
+		RO
+

Unless I am missing something, this is just another temperature sensor.
You should just name it temp2_input; there should be no need to change the API.

Guenter

I'm not very sure what you mean. Yes, it does be another sensor, but it only can be accessed by MSR_IA32_PACKAGE_THERM_STATUS, not original register MSR_IA32_THERM_STATUS. IMO, temp2_input should mean another same MSR based on per CPU, but apparently, here it's not. Please fix me.


_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors



[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux