Op 07-05-10 18:04, Oliver Neukum schreef: > From 505056649f5ecb1ebb086981243b9870ce961a87 Mon Sep 17 00:00:00 2001 > From: Oliver Neukum <oliver@xxxxxxxxxx> > Date: Fri, 7 May 2010 18:02:07 +0200 > Subject: [PATCH] hp_accel: Fix race in device removal > > The work queue has to be flushed after the device has been made > inaccessible. > > Signed-off-by: Oliver Neukum <oneukum@xxxxxxx> Ah, flushing the work before unregistering the device seemed more logical... but now that you mention it, I understand the race. Thanks Acked-by: Eric Piel <eric.piel@xxxxxxxxxxxxxxxx> > --- > drivers/hwmon/hp_accel.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/hwmon/hp_accel.c b/drivers/hwmon/hp_accel.c > index c8ab505..7580f55 100644 > --- a/drivers/hwmon/hp_accel.c > +++ b/drivers/hwmon/hp_accel.c > @@ -328,8 +328,8 @@ static int lis3lv02d_remove(struct acpi_device *device, int type) > lis3lv02d_joystick_disable(); > lis3lv02d_poweroff(&lis3_dev); > > - flush_work(&hpled_led.work); > led_classdev_unregister(&hpled_led.led_classdev); > + flush_work(&hpled_led.work); > > return lis3lv02d_remove_fs(&lis3_dev); > } _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
