OK, here's the new patch. It has most of the comments incorporated. The section I'm most unsure of is the error handling in ads7871_probe. In ads7871_probe, I do check that one register is written correctly this ensures that there is really a chip there, but I just set err to -1, is that OK? What should the error be for a chip that's not actually on the bus? thanks, Paul _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors