On Sat, 6 Feb 2010 15:38:08 +0100, Wolfram Sang wrote: > > > You can have reading vdd from sysfs also update the cache, but then you > > should also read data->ref_is_vdd at the same time. If the user is > > going to always read all the values at once then this is the most > > efficient approach. > > Yup. Just if not, then we will have another useless read (reading adc_ref_vdd > when we always want to know vdd) as on embedded boards, sysfs is often used > directly. Also, I can't factor out the caching-routine, as show_input() needs > vdd only if adc_ref_vdd is set. Adding a force_flag for always reading vdd to a > factored out function seems a bit too complex for that case to me. I think I'll > leave it at the current state: show_input() does the caching, show_vdd() always > reads from the chip. We might end up reading vdd twice within a second. Well, > it shouldn't hurt that much. Sure, fine with me. > (...) > Have a nice weekend! Thank you, same to you! -- Jean Delvare _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
