---------- Forwarded message ----------
From: Lu Zhihe <tombowfly@xxxxxxxxx>
Date: 2009/10/13
Subject: Re: [Module] hwmon: GM/GME965 GM45 and more
chips IGP thermal report
To: Jean Delvare <khali@xxxxxxxxxxxx>
Hi Jean,
2009/10/10 Jean Delvare <khali@xxxxxxxxxxxx>:
> Hi Lu,
>> From: Lu Zhihe <tombowfly@xxxxxxxxx>
>>
>> Subject: [PATCH] sensors-detect add gm965temp detected for lm-sensors
>>
>> Signed-off-by: Lu Zhihe <tombowfly@xxxxxxxxx>
>>
>> ---
>>
>> --- prog/detect/sensors-detect.orig 2009-10-09 21:43:12.000000000 +0000
>> +++ prog/detect/sensors-detect 2009-10-09 21:50:13.000000000 +0000
>> @@ -147,6 +147,16 @@ $revision =~ s/ \([^()]*\)//;
>> procid => "Intel SCH",
>> driver => "i2c-isch",
>> }, {
>> + vendid => 0x8086,
>> + devid => 0x2a00,
>> + procid => "Intel GM965",
>> + driver => "gm965temp",
>> + }, {
>> + vendid => 0x8086,
>> + devid => 0x2a10,
>> + procid => "Intel GME965",
>> + driver => "gm965temp",
>> + }, {
>
> This part is wrong: these chips are not I2C/SMBus masters!
Yes, I miss the I2C/SMBus Comment, and make a mistake. Fix it on new patch.
>
>> vendid => 0x1106,
>> devid => 0x3040,
>> procid => "VIA Technologies VT82C586B Apollo ACPI",
>> @@ -1860,6 +1870,10 @@ use vars qw(@cpu_ids);
>> driver => "i5k_amb",
>> detect => \&intel_amb_detect,
>> }, {
>> + name => "Intel GM/GME965 thermal sensor",
>> + driver => "gm965temp",
>> + detect => \&intel_gm965_detect,
>> + }, {
>> name => "VIA C7 thermal and voltage sensors",
>> driver => "c7temp",
>> detect => \&c7temp_detect,
>> @@ -5301,6 +5315,15 @@ sub intel_amb_detect
>> return;
>> }
>>
>> +sub intel_gm965_detect
>> +{
>> + if ((exists $pci_list{'8086:2a00'}) || # Intel GM965
>> + (exists $pci_list{'8086:2a10'})) { # Intel GME965
>> + return 9;
>> + }
>> + return;
>> +}
>> +
>
> This part is correct, however we want to add all the other chips
> supported by your driver, right? Please send an updated patch with all
> the chips. It's OK to have a single entry in @cpu_ids if you want, but
> all PCI IDs must be listed in intel_gm965_detect().
I am not sure gm965temp could work for all the gm965+ chipsets,
while, I just add them in this patch.
Only GM965/GME965 chipsets are tested and works. GM45 tested on Lenovo
T400 does't work, it always report 0xFF on the TR1 register. Tobias
got some simliar tested result, while, it may be work on other
machine. Many Desktop chipsets G3x and G4x don't test at all.
>
> Thanks,
> --
> Jean Delvare
>
From: Lu Zhihe <tombowfly@xxxxxxxxx>
Subject: [PATCH] sensors-detect add gm965temp detected for lm-sensors 3.1.1
Signed-off-by: Lu Zhihe <tombowfly@xxxxxxxxx>
---
--- lm-sensors.svn.orig/prog/detect/sensors-detect 2009-10-09
21:43:12.000000000 +0000
+++ lm-sensors.svn/prog/detect/sensors-detect 2009-10-13
21:23:33.000000000 +0000
@@ -1860,6 +1860,10 @@ use vars qw(@cpu_ids);
driver => "i5k_amb",
detect => \&intel_amb_detect,
}, {
+ name => "Intel GM/GME965 thermal sensor",
+ driver => "gm965temp",
+ detect => \&intel_gm965_detect,
+ }, {
name => "VIA C7 thermal and voltage sensors",
driver => "c7temp",
detect => \&c7temp_detect,
@@ -5301,6 +5305,24 @@ sub intel_amb_detect
return;
}
+sub intel_gm965_detect
+{
+ if ((exists $pci_list{'8086:2a00'}) || # Intel GM965
+ (exists $pci_list{'8086:2a10'}) || # Intel GME965
+ (exists $pci_list{'8086:2a40'}) || # Intel GM45, Follow
up chipsets are untested
+ (exists $pci_list{'8086:29b0'}) || # Intel Q35
+ (exists $pci_list{'8086:29c0'}) || # Intel G33
+ (exists $pci_list{'8086:29d0'}) || # Intel Q33
+ (exists $pci_list{'8086:2e10'}) || # Intel Q45
+ (exists $pci_list{'8086:2e20'}) || # Intel G45
+ (exists $pci_list{'8086:2e30'}) || # Intel G41
+ (exists $pci_list{'8086:2e40'}) || # Intel B43_BASE
+ (exists $pci_list{'8086:2e90'})) { # Intel B43_SOFT_SKU
+ return 9;
+ }
+ return;
+}
+
sub coretemp_detect
{
my $probecpu;
---
Thx
Lu Zhihe
--
Thx
Lu Zhihe
_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
