Hallo Uwe, On Fri, 9 Oct 2009 11:16:51 +0200, Uwe Kleine-König wrote: > From: Luotao Fu <l.fu@xxxxxxxxxxxxxx> > > This driver provides support for the ADC integrated into the > Freescale MC13783 PMIC. > > Signed-off-by: Luotao Fu <l.fu@xxxxxxxxxxxxxx> > Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > Cc: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> > Cc: Hans de Goede <hdegoede@xxxxxxxxxx> > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > Cc: Eric Piel <eric.piel@xxxxxxxxxxxxxxxx> > Cc: Jean Delvare <khali@xxxxxxxxxxxx> > --- > Hello again, > > just found an uncommited change in the tested driver. > > Sorry for the inconvenience. > > Best regards > Uwe > > Changes since v4: > > - remove unused function mc13783_adc_read_raw > > Changes since v3a: > > - remove units from sysfs files and round to integer > - undo zero padding of the sysfs device entries > - make some variables static > - some naming fixes (e.g. s/-/_/ for the content of name) > - use ASCII-only for Documentation/hwmon/mc13783 > - don't include unneeded headers > - some style fixes requested by Jean Delvare > - move probe function to .init.text > - set platform driver data earlier to fix race condition > > Changes since v3: > > - remove channels 0, 1, 3 and 4 as reading them needs more work > - report actual voltages not raw values > - some cosmetics > - zero pad the sysfs device entries > > Changes since v2: > > - Add Documentation Documentation/hwmon/mc13783 > - use sysfs_create_group > > Changes since v1: > > - add MODULE_ALIAS > - __init -> __devinit in probe function > - use platform_driver_probe instead of platform_driver_register > > --- > Documentation/hwmon/mc13783_adc | 50 +++++++++ > drivers/hwmon/Kconfig | 6 + > drivers/hwmon/Makefile | 1 + > drivers/hwmon/mc13783-adc.c | 225 +++++++++++++++++++++++++++++++++++++++ > 4 files changed, 282 insertions(+), 0 deletions(-) > create mode 100644 Documentation/hwmon/mc13783_adc > create mode 100644 drivers/hwmon/mc13783-adc.c Looks good this time. Patch applied, scheduled for kernel 2.6.33. > Now calling sensors I get: > > mc13783_adc-isa-0000 > Adapter: ISA adapter > in2: +4.32 V > in5: +0.00 V > in6: +0.00 V > in7: +0.00 V > in8: +0.00 V > in9: +0.00 V > in10: +0.00 V > in11: +0.00 V > in12: +0.52 V > in13: +0.47 V > in14: +0.47 V > in15: +0.01 V > > I wonder why the name contains "isa". Is this something I need to fix > in the driver? No, it's fine. libsensors names "isa" all platform devices, for historical compatibility reasons. -- Jean Delvare _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
