Op 07-10-09 18:31, Jonathan Cameron schreef: > Just a quick heads up wrt overlapping work. > > For the i2c support Kalhan Trisal has been posting patches for i2c > support for this > driver to the lm-sensors list for some time and the latest version of that > set is also pretty clean. You mean this post, right? http://lists.lm-sensors.org/pipermail/lm-sensors/2009-August/026505.html "Accelerometer driver for STMicroeletronics-LIS331DL-three-axis-digital" Thanks for the heads up, I had never heard of this driver before. Well, it's for the LIS331DL, not the LIS3LV02DL (12 bits) or the LIS302DL (8 bits) (both supported by lis3lv02d driver). That said, according to the specs, it seems to be _very_ similar to the LIS302DL, they even report the same "who_am_i" value. Just some special features are different (free fall detection for instance). > > The changes in these two patch sets should probably be reconciled before > merging. Yes, at least from a 5 minutes look, it seems it should be possible to merge both drivers. Samu's i2c implementation is pretty clean as well and IMHO it seems the Right Thing to have all the bus specific parts (I²C, SPI, ACPI/HP) "inheriting" from a generic driver. So I think we should try to merge everything in the lis3lv02d driver. Kalhan, would you mind having a look at the patch from Samu, and see what is required to get your LIS331DL working with the lis3lv02d driver? It should be very little and avoid duplication of efforts :-) See you, Eric _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
