On Wed, Aug 12, 2009 at 05:05:29PM +0200, Sascha Hauer wrote: > --- > drivers/hwmon/Kconfig | 6 ++ > drivers/hwmon/Makefile | 1 + > drivers/hwmon/mc13783-adc.c | 181 +++++++++++++++++++++++++++++++++++++++++++ Ideally there should be a Documentation/hwmon describing the chip and the hwmon features it has. > + for (i = 0; i < entries; i++) { > + ret = device_create_file(&pdev->dev, > + &mc13783_adc_ctl[i].dev_attr); > + if (ret) { > + dev_err(&pdev->dev, > + "device_create_file failed with %d.\n", ret); > + goto out_err; > + } > + } Could use sysfs_create_group() here.