On Thu, Aug 06, 2009 at 01:54:17PM +0530, Ramesh Agarwal wrote: > However what I wanted to do was to see if I could get any early review > comments so that I don't have to make any drastic changes finally when > I submit for inclusion. The driver is fairly simple and small (about > 300 lines), so was wondering if someone on this list could review the > code for me. I have done all the basic sanity checks like > functionality, no warning, coding style check and the like. Just post your driver, mentioning that it depends on this other code (and if possible providing a link so that people can look at it during review).