On Sat, 20 Jun 2009 01:02:52 +0200, Hans J. Koch wrote: > On Fri, Jun 19, 2009 at 11:26:35PM +0200, Jiri Slaby wrote: > > Add omitted update_lock to one switch/case in set_div. > > Ahem, yes, thanks! > > > > > Signed-off-by: Jiri Slaby <jirislaby at gmail.com> > > Signed-off-by: Hans J. Koch <hjk at linutronix.de> > > > --- > > drivers/hwmon/max6650.c | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/hwmon/max6650.c b/drivers/hwmon/max6650.c > > index 86142a8..58f66be 100644 > > --- a/drivers/hwmon/max6650.c > > +++ b/drivers/hwmon/max6650.c > > @@ -418,6 +418,7 @@ static ssize_t set_div(struct device *dev, struct device_attribute *devattr, > > data->count = 3; > > break; > > default: > > + mutex_unlock(&data->update_lock); > > dev_err(&client->dev, > > "illegal value for fan divider (%d)\n", div); > > return -EINVAL; Applied, thanks. -- Jean Delvare