[PATCH] bug in sensors.d reading: not all filesystems can return dt_type != DT_UNKNOWN

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello!
  Most filesystems (in particular - reiserfs, jfs, xfs, nfs); maybe,
some legacy installation of ext2/3 too) always return dirent->dt_type =
DT_UNKNOWN, so libsensors fails to parse /etc/sensors.d.
  Also, symlink (DT_LNK) can point to directory, or FIFO/socket/device
(very bad!) - current check insufficient anyways.
  I've attached [somewhat hackerish] patch to solve both problem.
=== cut !man 3 readdir ===
Currently,  only  some  file systems (among them: ext2, etx3, and ext4)
have full support returning the file type in d_type.  All  applications
must properly handle a return of DT_UNKNOWN.
=== cut ===
  Maybe, it would be better to remove dt_type check and use stat() always.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lm_sensors-3.1.0-dt_unknown-fix-3.patch
Type: text/x-diff
Size: 1545 bytes
Desc: not available
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20090605/c8d5c2b3/attachment-0001.bin 


[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux