Hi, 2009/5/26 Ben Dooks <ben at simtec.co.uk>: > + ? ? ? /* Register with the core ADC driver. */ > + > + ? ? ? hwmon->client = s3c_adc_register(dev, NULL, s3c_hwmon_adcdone, 0); I have been trying out this code and when compiling I get a warning, CC [M] drivers/hwmon/s3c-adc.o drivers/hwmon/s3c-adc.c: In function 's3c_hwmon_probe': drivers/hwmon/s3c-adc.c:275: warning: passing argument 3 of 's3c_adc_register' from er type s3c_hwmon_adcdone is a callback function and register function is expecting something like "void (*conv)(unsigned d0, unsigned d1)" I quite do not understand it very well to propose a patch. Cheers -- H?ctor Or?n