On 05/19/2009 10:39 AM, Engelmayer Christian wrote: > From: Christian Engelmayer<christian.engelmayer at frequentis.com> > > Added support for the GPIO definition/status registers and the alarm > enable/status > registers provided by the MAX6650/MAX6651 fan-speed regulator and monitor > chips. > > Signed-off-by: Christian Engelmayer<christian.engelmayer at frequentis.com> <snip> Hmm, I'm not sure we should be exporting gpio functionality like this. First of all the gpio function usually is fixed by how the IC is wired up, so I would expect that to be set by the BIOS / firmware. And when not, this should be set through a board configuration file, exporting this to userspace feels wrong. The same can be said for toggling the pin when its an output, its function will depend upon how its wired up again, and I would expect some higher level interface (like an ACPI interface or whatever) expose its functionality in a more sane way. Regards, Hans
