[PATCH v2 1/7] sensord: Remove commandline interface.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 12, 2009 at 06:23:21PM +0200, Jean Delvare wrote:
> On Mon, 11 May 2009 18:00:23 +0200, Andre Prendel wrote:
> > Remove the hidden commandline interface of sensord.
> > 
> > Sensord can be invoked as an console application. Therefor a link
> > named sensors pointing to sensord is needed. That is very
> > intransparent and IMO useless. Printing sensor values to console is
> > done by the sensors tool.
> > 
> > Changes in v2:
> > 
> > Remove references to isDaemon.
> > Rename daemonShortOptions to shortOptions and daemonLongOptions to
> > longOptions.
> > Remove commandline flags doScan and doSet. They are needless without
> > the CLI.
> > Cleanup main().
> 
> Looks good to me.
> 
> > Jean, there is some more useless stuff after the removal of the CLI
> > (e.g. the DO_SET action in doChip). I would prefer first to get this
> > series applied and remove the remaining stuff in further patches. Is
> > this OK for you?
> 
> Yes, this is OK with me. Function setChips() can be killed too.

I've just applied the whole series.

Thanks,
Andre

> 
> -- 
> Jean Delvare



[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux