On Mon, 11 May 2009 18:04:11 +0200, Andre Prendel wrote:
> This patch does some refactoring of the loadConfig()
> function.
>
> * Simplifying the conditions makes code flow clearer and eliminates
> long lines (> 80 chars).
> * Removed useless stat() call.
> * Return -1 in error case, instead of several positive values (never defined).
>
> Changes in v2:
>
> Blank line before the first #include.
> Fix typo.
> Bring back logging (reload configuration).
> Consistent error messages.
> Drop reading configuration from stdin.
> Fix logging (if fopen() fails).
> Cleanup sensors before reloading configuration.
> Fix compile warning.
> Don't print error value if reloadLib() fails.
Looks almost OK, just one minor issue:
> ---
>
> lib.c | 74 +++++++++++++++++++++++++++++++-------------------------------
> sensord.c | 4 +--
> 2 files changed, 40 insertions(+), 38 deletions(-)
>
> Index: quilt-sensors/prog/sensord/lib.c
> ===================================================================
> --- quilt-sensors.orig/prog/sensord/lib.c 2009-04-26 22:11:03.000000000 +0200
> +++ quilt-sensors/prog/sensord/lib.c 2009-04-26 22:13:09.000000000 +0200
> (...)
> + /* Load default configuration. */
> + if (!cfgPath) {
> + if (reload) {
> sensorLog(LOG_INFO, "configuration reloading");
> - sensors_cleanup();
> + sensors_cleanup();
You're adding leading white spaces!
--
Jean Delvare
