Hi Jean, As Jordan did not get around to doing this and the 2.6.29 merge window is near I've fixed the last few outstanding issues from my review(s) of his adt7475 I've done myself. Attached is a new version of the adt7475 with: * all issues review found fixed * converted to the new i2c driver style * a few more registers needed reading in store methods * corrected register to voltage conversion (more accurate) * some style fixes * locking around show functions where the value shown depends on more then 1 reg. * read limit registers only once every 60 seconds * rename pwm_min and pwm_max to pwm_auto_pointX_pwm, as the control the scope between which the pwm gets changed in auto mode * remove tempX_crit_alarm (only one crit alarm flag for all 3 channels) I hope this is ok now to be queued for 2.6.29 Thanks & Regards, Hans -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: hwmon-add-adt7475-driver.patch Url: http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20081219/b383f684/attachment.pl