On Wed, 19 Nov 2008, Jean Delvare wrote: > On Wed, 19 Nov 2008 01:51:08 -0800 (PST), Trent Piepho wrote: >> On Tue, 18 Nov 2008, David Brownell wrote: >>> --- >>> drivers/i2c/busses/i2c-gpio.c | 10 ++ >>> drivers/i2c/i2c-core.c | 155 ++++++++++++++++++++++++++++++++++++++++ >>> include/linux/i2c.h | 14 +++ >>> 3 files changed, 179 insertions(+) >> >> Can this be made optional? Seeing as nothing uses it yet and it increases a >> brunch of core structs' sizes. > > Did you actually check the size increase? struct i2c_driver is added > one pointer, so 4 or 8 bytes, hardly worth mentioning. struct > i2c_adapter is added 72 bytes on x86-64, to 1360 bytes initially so an > increase of less than 6%. Is this really such a big issue? I doubt it. > You don't have that many i2c_adapters registered on any given system > for it to really matter, methinks. Except every other subsystem in the kernel does the same thing. Each release of 2.6 is significantly more bloated than the last and this is how it happens. One "it's not that much wasted" change at a time. > Making it optional would have its problems as well. Either the drivers > which implement or make use of SMBus alert would have to depend on said > option being enabled, or you'd have to put #ifdefs in all these drivers What's so hard about having them depend on smbus alert support? They already depend on I2C and so on. If any drivers ever get code for this, how hard is it to add one dependency or select to their Kconfig section?
