On Fri, 07 Nov 2008 11:04:51 -0800 Harvey Harrison <harvey.harrison at gmail.com> wrote: > On Fri, 2008-11-07 at 10:56 -0800, Darrick J. Wong wrote: > > New driver to play with. As Jean mentioned a couple of years ago, > > this > > chip is a beast with odd combinations of 8 fans, 4 temperatures, and > > 13 voltage sensors. This driver has been tested on an IntelliStation > > Z30. > > > > Signed-off-by: Darrick J. Wong <djwong at us.ibm.com> > > --- > > +#define MASK_AND_SHIFT(value, prefix) \ > > + (((value) & prefix##_MASK) >> prefix##_SHIFT) > > + > > I'm not sure, but doesn't this exist somewhere in the common kernel > headers. No, core kernel doesn't have a macro which requires that the caller previously defined foo_MASK and foo_SHIFT. Only drivers are allowed to get away with such fugliness ;) > > +#define ROUND_DIV(x, divisor) (((x) + ((divisor) / 2)) / (divisor)) > > DIV_ROUND_UP ? That's different. This one should be called ROUND_CLOSEST or something like that.
