Hi Darrick, On Thu, 9 Oct 2008 14:25:23 -0700, Darrick J. Wong wrote: > On Thu, Oct 09, 2008 at 12:31:17PM +0200, Jean Delvare wrote: > > > Should we implement a kernel thread / tasklet / whatever it is called > > these days that would actively read the needed temperature values (and > > only these) every 5 seconds as soon as automatic fan speed control is > > enabled? The current implementation seems dangerous to me, as > > illustrated by the report you quoted above. > > That would work, though it'll cause wakeups even if nobody's reading the > sensor. However, since one would generally have to run sensors-detect > to know that it's there in the first place, I suppose anyone actually > loading the module is doing so with the intent to monitor anyway. My proposal is to have such a kernel thread running only when automatic fan speed is enabled. According to the datasheet, this isn't the default, so loading the adt7470 driver alone wouldn't start the thread. The thread would start running only once at least one fan has been switched to automatic mode, and would stop as soon as all fans are switched back to manual mode. -- Jean Delvare
