On Wed, Oct 08, 2008 at 11:25:29AM +0200, Jean Delvare wrote: > Hi Darrick, > > On Mon, 06 Oct 2008 18:18:44 -0700, Darrick J. Wong wrote: > > It turns out that Tmin/Tmax should be attached to the temperature sensors, not > > to the pwm control. Fix my misinterpretation of the datasheet. > > Really? I'm confused. The ADT7470 has 4 PWM outputs and 10 temperature > inputs. There are only 4 Tmin registers. How can they be attached to > temperature inputs? What about inputs temp5 to temp10? I think your > original interpretation is correct and Tmin is attached to a PWM > channel, and this patch is incorrect. What makes you think otherwise? I think I confused myself, because the datasheets for the 7473/7462 claim that Tmin are attached to the temperature inputs, not to the pwm outputs. Clearly not the case for the 7470. Nack on this patch. --D
