Marc Hulsman wrote: >> And here you store the register val + 1 again, making show_pwmenable >> actually show the less value, unless pwm#_enable is read very quickly after >> a write, in which case w83791d_update won't do anything and the shown >> pwm_enable value will be one to small. >> >> I think it would be best to consistently store the val as seen by userspace >> - 1 (iow the actual reg val) in pwm_enable (as you do in store_pwmenable) >> and then add the + 1 when showing it. > > Thanks for spotting that one, I should have seen it. Hereby a new version of > the patch: > > --- > Add support for pwm_enable. > > Signed-off-by: Marc Hulsman <m.hulsman at tudelft.nl> > Looks good now: Acked-by: Hans de Goede <j.w.r.degoede at hhs.nl> Regards, Hans
