[PATCH] hwmon: (thmc50) Safer device detection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Accepting all values >= 0xc0 as the ADM1022/THMC50 device ID is too
permissive. Only allow the ID range we know these devices may use.

Signed-off-by: Jean Delvare <khali at linux-fr.org>
Cc: Krzysztof Helt <krzysztof.h1 at wp.pl>
---
Krzysztof, can you please review and ack this patch? Thanks.

 drivers/hwmon/thmc50.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- linux-2.6.26-rc5.orig/drivers/hwmon/thmc50.c	2008-04-17 04:49:44.000000000 +0200
+++ linux-2.6.26-rc5/drivers/hwmon/thmc50.c	2008-06-11 17:19:44.000000000 +0200
@@ -295,7 +295,8 @@ static int thmc50_detect(struct i2c_adap
 		kind = thmc50;
 	else if (kind < 0) {
 		err = -ENODEV;
-		if (revision >= 0xc0 && ((config & 0x10) == 0)) {
+		if (revision >= 0xc0 && revision <= 0xdf &&
+		    (config & 0x10) == 0) {
 			if (company == 0x49) {
 				kind = thmc50;
 				err = 0;


-- 
Jean Delvare




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux